Add multi-process version of xmap_reader to take place of multi-thread version for a significant acceleration and add seqbin data parser for internal 1w data training. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add seqbin data parser to adapt to internal 1w data training.
pkuyym
reviewed
Oct 8, 2017
deep_speech_2/data_utils/audio.py
Outdated
| @@ -115,6 +117,46 @@ def slice_from_file(cls, file, start=None, end=None): | |||
| return cls(data, sample_rate) | |||
|
|
|||
| @classmethod | |||
| def from_sequence_file(cls, filepath): | |||
| """Create audio segment from sequence file. | |||
There was a problem hiding this comment.
Please add some simple comments about sequence file.
deep_speech_2/data_utils/utility.py
Outdated
| yield sample | ||
| sample = out_queue.get() | ||
| finish = 1 | ||
| while finish < process_num: |
There was a problem hiding this comment.
I'm not sure why we need two while loop here? The only exit condition is finish >= process_num.
There was a problem hiding this comment.
Yes. We can remove the first loop and set finish = 0 for Line 155, without any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #354
Done:
xmap_reader_mpto take place of multi-thread version ofpaddle.reader.xmap_reader.This speeds up the training with the internal 1w dataset by more than 3X, and now the GPU utilization rises back to 81% (from 15%).