Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix resnet dygraph model time print #4868

Merged
merged 2 commits into from
Sep 23, 2020
Merged

fix resnet dygraph model time print #4868

merged 2 commits into from
Sep 23, 2020

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Sep 22, 2020

根据近期共识的，新的性能统计规范修改了resnet model：

  1. batch_time = reader time + exe.run time
  2. 求log_interval步的平均时间

本模型有四个时间，train_batch_cost，train_reader_cost，这两个时间的计算都是正确的，只是没有取平均。因此，本PR对这两个时间再求log_interval步的平均

wanghuancoder
wanghuancoder approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
fix code format
99a9490 
test=develop
@luotao1 luotao1 merged commit 38ada7f into PaddlePaddle:develop Sep 23, 2020
@luotao1 luotao1 deleted the resnet_benchmark branch September 23, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luotao1 @Xreki @wanghuancoder