Support variable input batch and SortaGrad. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinghai-sun
approved these changes
Jun 12, 2017
deep_speech_2/audio_data_utils.py
Outdated
| :type manifest: list | ||
| :param batch_size: batch size. | ||
| :type batch_size: int | ||
| """ |
There was a problem hiding this comment.
Please add a :return: and :rtype:
deep_speech_2/audio_data_utils.py
Outdated
| :type sort_by_duration: bool | ||
| :param sortagrad: Sort the audio clips by duration in the first epoc | ||
| if set True (for SortaGrad). | ||
| :type sortagrad: bool | ||
| :param shuffle: Shuffle the audio clips if set True. |
There was a problem hiding this comment.
Since it is not a thorough instance-wise shuffle, but a specific batch-wise shuffle. Could you add more explanation to users?
Besides, rename shuffle to batch_shuffle?
There was a problem hiding this comment.
在__batch_shuffle__里增加了更多注释。
deep_speech_2/audio_data_utils.py
Outdated
| def instance_reader_creator(self, | ||
| manifest_path, | ||
| sort_by_duration=True, | ||
| batch_size, |
There was a problem hiding this comment.
Here batch_size is for batch_shuffle,
- put batch_size just before shuffle
- rename batch_size --> batch_shuffle_size (否则有点奇怪，因为函数名是instance reader，用户不知道为什么和batch_size有关？）
for a better understanding?
There was a problem hiding this comment.
有道理。我把代码做了调整，instance_reader_creator()只保留如何读取instance。
deep_speech_2/audio_data_utils.py
Outdated
| def instance_reader_creator(self, | ||
| manifest_path, | ||
| sort_by_duration=True, | ||
| batch_size, | ||
| sortagrad=True, | ||
| shuffle=False): |
There was a problem hiding this comment.
shuffle-->batch_shuffle ?
deep_speech_2/audio_data_utils.py
Outdated
| @@ -296,7 +319,7 @@ def batch_reader_creator(self, | |||
| batch_size, | |||
| padding_to=-1, | |||
| flatten=False, | |||
| sort_by_duration=True, | |||
| sortagrad=False, | |||
| shuffle=False): | |||
There was a problem hiding this comment.
shuffle --> batch_shuffle
qingqing01
commented
Jun 12, 2017
| manifest_path, | ||
| sort_by_duration=True, | ||
| shuffle=False): | ||
| def __batch_shuffle__(self, manifest, batch_size): |
There was a problem hiding this comment.
这里确实需要batch_size，因此没有改成batch_shuffle_size。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #75