Enable ParallelExecutor in SSD-MobileNet and Refine code. #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Apr 12, 2018
| batch_size, | ||
| num_passes, | ||
| model_save_dir, | ||
| pretrained_model=None): |
There was a problem hiding this comment.
parallel_do need have an argument to define using nccl or not. The default value does not use nccl.
fluid/object_detection/train.py
Outdated
| return os.path.exists(os.path.join(pretrained_model, var.name)) | ||
| fluid.io.load_vars(exe, pretrained_model, predicate=if_exist) | ||
|
|
||
| train_exe = fluid.ParallelExecutor(use_cuda=True, loss_name=loss.name) |
There was a problem hiding this comment.
line 218 and line 227 is not consistent, currently ParallelExecutor only allows to use GPU.
There was a problem hiding this comment.
Here change use_cuda=arg.use_gpu. Thanks!
| for _, data in enumerate(test_reader()): | ||
| test_map = exe.run(test_program, | ||
| feed=feeder.feed(data), | ||
| fetch_list=[accum_map]) |
There was a problem hiding this comment.
exe.run is not the format of parallel_exe.
There was a problem hiding this comment.
The testing use Executor, not ParallelExecutor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.