Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine quotes' format and comments & add new operators #40

Merged
merged 5 commits into from
May 4, 2018

Conversation

kuke
Copy link

@kuke kuke commented May 2, 2018

Resolve #41

@kuke kuke changed the title Unify quotes' format & add comments to common ops Refine quotes' format and comments & add new operators May 2, 2018
@@ -263,9 +263,17 @@ def eval_onnx_node(self):
onnx_graph = make_graph(node_list, self.op_type, inputs, outputs)
onnx_model = make_model(onnx_graph, producer_name='unittest')

# Expand input dictionary if there are tensor arrays
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. the input of concat_op:

self.inputs = {'X': [('x0', self.x0), ('x1', self.x1), ('x2', self.x2)]}

Copy link
Collaborator

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

@kuke kuke merged commit 497bd0b into PaddlePaddle:develop May 4, 2018
Zeref996 pushed a commit to Zeref996/Paddle2ONNX that referenced this pull request Aug 24, 2021
* add base test case

* add base cases

* add cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants