Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Add Recordio File Reader #22

Merged
merged 6 commits into from
Jun 22, 2018
Merged

Conversation

kexinzhao
Copy link
Collaborator

No description provided.

@tonyyang-svail tonyyang-svail self-requested a review June 21, 2018 03:32
src/tape.cc Outdated
@@ -125,7 +125,7 @@ void Tape::AddOp(const std::string &type,
const VariableHandleMap &in_vars,
VariableHandleMap out_vars,
const framework::AttributeMap &attrs) {
InferShapeAndVarType(type, in_vars, &out_vars, attrs);
// InferShapeAndVarType(type, in_vars, &out_vars, attrs);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/test_tape.cc Outdated
@@ -24,6 +25,37 @@ using paddle::tape::Fill;
using paddle::tape::reset_global_tape;
using paddle::tape::get_global_tape;

VariableHandle create_recordio_file_reader(std::string filename,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this function to function.h

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kexinzhao kexinzhao changed the title Add feeder Add Recordio File Reader Jun 21, 2018
Copy link
Collaborator

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kexinzhao kexinzhao merged commit fa1f65d into PaddlePaddle:develop Jun 22, 2018
@kexinzhao kexinzhao deleted the data_feeder branch June 22, 2018 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants