This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add accuracy func and test mnist accuracy #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyyang-svail
approved these changes
Jun 28, 2018
src/example/mnist/test_mnist.cc
Outdated
| Linear linear3(200, 10, "relu"); | ||
| std::string filename1 = "/tmp/mnist_train.recordio"; | ||
| std::string filename2 = "/tmp/mnist_test.recordio"; | ||
| PADDLE_ENFORCE(is_file_exist(filename1), |
There was a problem hiding this comment.
Maybe put is_file_exist inside CreateRecordioFileReader
| @@ -110,6 +110,9 @@ class Linear { | |||
| {{"X", {pre_bias}}, {"Y", {b_}}}, | |||
| {{"Out", {pre_act}}}, | |||
| add_op_attrs); | |||
| if (act_.empty()) { | |||
There was a problem hiding this comment.
Maybe also make Conv support act_.empty()
There was a problem hiding this comment.
Done for both conv and batchnorm
src/function.h
Outdated
| reader->GetMutable<paddle::framework::ReaderHolder>()->ReadNext( | ||
| &data_holder); | ||
| } else { | ||
| return {}; |
There was a problem hiding this comment.
Will this return {} hide the check PADDLE_ENFORCE(!data_holder.empty(), "Error reading file.");?
There was a problem hiding this comment.
Good point. Revised.
kexinzhao
commented
Jun 28, 2018
src/function.h
Outdated
| reader->GetMutable<paddle::framework::ReaderHolder>()->ReadNext( | ||
| &data_holder); | ||
| } else { | ||
| return {}; |
There was a problem hiding this comment.
Good point. Revised.
| @@ -110,6 +110,9 @@ class Linear { | |||
| {{"X", {pre_bias}}, {"Y", {b_}}}, | |||
| {{"Out", {pre_act}}}, | |||
| add_op_attrs); | |||
| if (act_.empty()) { | |||
There was a problem hiding this comment.
Done for both conv and batchnorm
src/example/mnist/test_mnist.cc
Outdated
| Linear linear3(200, 10, "relu"); | ||
| std::string filename1 = "/tmp/mnist_train.recordio"; | ||
| std::string filename2 = "/tmp/mnist_test.recordio"; | ||
| PADDLE_ENFORCE(is_file_exist(filename1), |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accuracy is tested on the mnist test set.