Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitConsumerSpec uses mutable state in its corresponding Fixture #19

Open
rodoherty1 opened this issue Oct 10, 2017 · 0 comments
Open

Comments

@rodoherty1
Copy link
Contributor

The static analysis check (scala-style) by default prohibits mutable state in application code and unit tests. The "prohibit mutable state" rule was disabled during the hackathon to facilitate adding of some unit tests.

This rule should be reinstated.

Please refactor RabbitConsumerFixture so that mutable state is not required for the tests to pass.

sean-halpin pushed a commit that referenced this issue Oct 17, 2017
sean-halpin pushed a commit that referenced this issue Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant