fix(oncall-api): return all users from lowest escalation level #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: 0.4.0
release: 0.4.1
Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…n/ip-2.0.1 build(deps): Bump ip from 2.0.0 to 2.0.1
release: 0.4.3
Instead of return all users that match the escalation level of the first user returned in the oncall list, return users that match the lowest escalation level. Previously, if a higher escalation level user was the first item in the array, only users at that same level would be returned. Fixes PagerDuty/backstage-plugin#77
|
@t1agob could you take a look at this please? |
|
Hi @brianphillips. Approved! I have changed the base branch to comply with our guidelines. I'll work on merging this to main and release a new version shortly. |
t1agob
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of return all users that match the escalation level of the first user returned in the oncall list, return users that match the lowest escalation level.
Previously, if a higher escalation level user was the first item in the array, only users at that same level would be returned.
Issue number: Fixes #34
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.