Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release 0.8.1 breaks use of different PagerDuty API host #74

Closed
pcgqueiroz opened this issue Feb 22, 2024 · 2 comments
Closed

New release 0.8.1 breaks use of different PagerDuty API host #74

pcgqueiroz opened this issue Feb 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working high priority High priority issue

Comments

@pcgqueiroz
Copy link

Describe the bug
The new release 0.8.1 that deprecates the proxy configuration in favor of using a backend plugin to make calls to the PagerDuty REST API does not offer the possibility to change the server base URL. Calls to the european server https://api.eu.pagerduty.com are not possible anymore.

Expected behavior
The possibility in the configuration to change the API server.

@pcgqueiroz pcgqueiroz added the bug Something isn't working label Feb 22, 2024
@pcgqueiroz pcgqueiroz changed the title New release 0.8.1 breaks use of different PagerDuty api host New release 0.8.1 breaks use of different PagerDuty API host Feb 22, 2024
@t1agob
Copy link
Collaborator

t1agob commented Feb 22, 2024

Thanks for reporting this @pcgqueiroz.

While the plugin continues to work it introduces additional latency if your PagerDuty instance is running in Europe for sure. I'll look into this with high priority and add support for an override like we already have for the events url.

@t1agob t1agob added the high priority High priority issue label Feb 22, 2024
@t1agob t1agob self-assigned this Feb 22, 2024
t1agob added a commit that referenced this issue Feb 22, 2024
### Description

This PR resolves an issue reported in backstage-plugin (#74) which
prevents users from overriding the REST API base url (e.g. for EU based
accounts). This feature was possible through the Backstage proxy
configuration.

With this, users will be able to add a new configuration to the
PagerDuty plugin in `app-config.yaml` like the example below.

```yaml
pagerDuty:
  apiBaseUrl: https://api.eu.pagerduty.com     #defaults to https://api.pagerduty.com
```

This feature in mainly implemented in
`@pagerduty/backstage-plugin-backend` but this PR updates the plugin
config schema accordingly.

**Issue number:** #74

### Type of change

- [ ] New feature (non-breaking change which adds functionality)
- [x] Fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

### Checklist

- [x] I have performed a self-review of this change
- [x] Changes have been tested
- [x] Changes are documented
- [x] Changes generate *no new warnings*
- [x] PR title follows [conventional commit
semantics](https://www.conventionalcommits.org/en/v1.0.0/)

If this is a breaking change 👇

- [ ] I have documented the migration process
- [ ] I have implemented necessary warnings (if it can live side by
side)

## Acknowledgement

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

**Disclaimer:** We value your time and bandwidth. As such, any pull
requests created on non-triaged issues might not be successful.
@t1agob t1agob mentioned this issue Feb 22, 2024
t1agob added a commit that referenced this issue Feb 22, 2024
### Description

This release resolves an issue reported in backstage-plugin (#74) which
prevents users from overriding the REST API base url (e.g. for EU based
accounts). This feature was possible through the Backstage proxy
configuration.

With this, users will be able to add a new configuration to the
PagerDuty plugin in `app-config.yaml` like the example below.

```yaml
pagerDuty:
  apiBaseUrl: https://api.eu.pagerduty.com     #defaults to https://api.pagerduty.com
```

This feature in mainly implemented in
`@pagerduty/backstage-plugin-backend` but this release updates the
plugin config schema accordingly.

## Acknowledgement

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

**Disclaimer:** We value your time and bandwidth. As such, any pull
requests created on non-triaged issues might not be successful.
@t1agob
Copy link
Collaborator

t1agob commented Feb 22, 2024

@pcgqueiroz This should be fixed now. Please upgrade to the latest version of the packages and follow the docs on how to configure/override the base REST API url.

latest versions:

@t1agob t1agob closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority issue
Projects
Development

No branches or pull requests

2 participants