service: do not omit support hours #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreateService() API contract has been randomly changed without a notice
to not accept the non-existence of the `support_hours` key. Creating a
service currently fails with:
```
Failed call API endpoint. HTTP response code: 400. Error: \u0026{2001 Invalid Input Provided [Support hours is required.]}
```
The API gladly accepts the same payload when `support_hours` is
_explicitly_ set to `null` in the resulting JSON.
|
Actually, this has been done already: #255. Let's merge that one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateService() API contract has been randomly changed without a notice
to not accept the non-existence of the
support_hourskey. Creating aservice currently fails with:
The API gladly accepts the same payload when
support_hoursisexplicitly set to
nullin the resulting JSON.