Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch more generic exceptions #49

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Catch more generic exceptions #49

merged 3 commits into from
Dec 14, 2020

Conversation

Deconstrained
Copy link
Collaborator

This catches all major exception types explicitly defined for requests and urllib3, including Timeout

@Deconstrained
Fix formatting in latest changelog entries
83ce700
@Deconstrained
More explicit error handling
546018c 
This casts a broader net over all the types of exceptions that requests and urllib3 can raise, for invoking network retry logic.
@Deconstrained Deconstrained mentioned this pull request Dec 14, 2020
Merged
@Deconstrained Deconstrained merged commit 4fdafe3 into master Dec 14, 2020
@Deconstrained Deconstrained deleted the generic-exceptions branch December 14, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Deconstrained @stmcallister