Add class for change events #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new change events api only has a single kind of endpoint, to submit change events. They are associated with a given service by the routing key. https://developer.pagerduty.com/docs/events-api-v2/send-change-events/ Also includes a small tweak to the error messaging to more easily clarify API error responses.
Deconstrained
requested changes
Apr 19, 2021
There was a problem hiding this comment.
@hunner This is great; thank you for contributing!
The only change I would make is moving event_timestamp into ChangeEventsAPISession as it is only used in that class.
hunner
force-pushed
the
add-change-event
branch
from
86e8074
to
bd634df
Compare
Deconstrained
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new change events api only has a single kind of endpoint, to submit
change events. They are associated with a given service by the routing
key.
https://developer.pagerduty.com/docs/events-api-v2/send-change-events/
Also includes a small tweak to the error messaging to more easily
clarify API error responses.