Embed time zone data into the provider's binary #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! When can we expect this to be released? |
|
Is there any reason why this is still not released? It's been 3 weeks with the broken latest release. |
|
We just updated and use atlantis. this missing change broke our terraform and we had to install Easy fix... but we would ask this be merged ASAP. |
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #477
To address the issue of running the provider in environments without time zone data installed, we can build in time zone data. The binary will still check OS hosted time zone data as a fallback.
Ref:
https://pkg.go.dev/time/tzdata
https://wawand.co/blog/posts/timezonedata-go115-7c2a25e7-dbdd-4b6b-8092-51cc2d0241ce/