Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Automation Actions' Runner association with a Team #607

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add support for Automation Actions' Runner association with a Team #607

merged 2 commits into from
Jan 9, 2023

Conversation

mrdubr
Copy link
Contributor

@mrdubr mrdubr commented Jan 5, 2023 •
edited

Add support for resource pagerduty_automation_actions_runner_team_association

New tests cases introduced:

$ make testacc TESTARGS="-run TestAccPagerDutyAutomationActionsRunnerTeamAssociation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyAutomationActionsRunnerTeamAssociation -timeout 120m
?   	github.com/terraform-providers/terraform-provider-pagerduty	[no test files]
=== RUN   TestAccPagerDutyAutomationActionsRunnerTeamAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsRunnerTeamAssociation_import (9.80s)
=== RUN   TestAccPagerDutyAutomationActionsRunnerTeamAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsRunnerTeamAssociation_Basic (7.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	(cached)

Depends on: heimweh/go-pagerduty#114

@mrdubr mrdubr changed the title prelim Add support for Automation Actions' Runner association with a Team Jan 5, 2023
@mrdubr mrdubr marked this pull request as ready for review January 5, 2023 20:26
imjaroiswebdev
imjaroiswebdev approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀

@mrdubr
prelim
6b725bb
@mrdubr
update to use heimweh/go-pagerduty
19df67d 
go mod edit -dropreplace github.com/heimweh/go-pagerduty
go get github.com/heimweh/go-pagerduty/pagerduty && go mod tidy && go mod vendor
@imjaroiswebdev imjaroiswebdev merged commit 56110dc into PagerDuty:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjaroiswebdev imjaroiswebdev imjaroiswebdev approved these changes

@stmcallister stmcallister Awaiting requested review from stmcallister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrdubr @imjaroiswebdev