Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem rendering when attaching cell references without specified orgin #17

Closed
mtfang opened this issue Jul 14, 2017 · 1 comment
Closed

Comments

@mtfang
Copy link
Contributor

mtfang commented Jul 14, 2017

The following doesn't work:

p = Path(Point(2000μm, 200μm))
straight!(p, 3000μm, styleCPW)
attach!(p, CellReference(any_cell), 1000μm)
fl = Cell("feedline", nm)
render!(fl, p, GDSMeta(BASE_METAL))

and throws the error

LoadError: DimensionError: 0.0 and 2000.0 μm are not dimensionally compatible.
while loading X:\Michael\Devices\PhononicShieldResonators.jl, in expression starting on line 126
in main at PhononicShieldResonators.jl:119
in #render!#7 at Devices\src\render\paths.jl:24
in render! at Devices\src\render\decorated.jl:11
in #render!#56 at Devices\src\render\decorated.jl:19
in _map at StaticArrays\src\mapreduce.jl:14
in macro expansion at StaticArrays\src\mapreduce.jl:23

but when you specify an explicit origin for the CellReference, you obtain the desired result without error:

p = Path(Point(2000μm, 200μm))
straight!(p, 3000μm, styleCPW)
attach!(p, CellReference(any_cell, Point(0.0μm, 0.0μm)), 1000μm) # different here
fl = Cell("feedline", nm)
render!(fl, p, GDSMeta(BASE_METAL))

The old behavior was that an origin did not need to be specified. Not really an issue, but thought I'd let you know.

ajkeller34 added a commit that referenced this issue Aug 24, 2017
@ajkeller34
Copy link
Contributor

I believe this is basically the same as #18 since I could not reproduce an issue after fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants