Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show method for MIME"text/plain" #213

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

giordano
Copy link
Collaborator

@giordano giordano commented Mar 5, 2019

Add a show method to print the value and unit parts in case they have custom representations with MIME text/plain

@coveralls
Copy link

coveralls commented Mar 5, 2019

Coverage Status

Coverage increased (+1.8%) to 79.067% when pulling 95af0c9 on giordano:show-mime into 82f8496 on ajkeller34:master.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #213 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #213     +/-   ##
=========================================
- Coverage   79.95%   79.56%   -0.4%     
=========================================
  Files          14       14             
  Lines         998     1003      +5     
=========================================
  Hits          798      798             
- Misses        200      205      +5
Impacted Files Coverage Δ
src/display.jl 78.37% <0%> (-12.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f8496...112c9f7. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #213 into master will decrease coverage by 0.09%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #213     +/-   ##
=========================================
- Coverage   79.95%   79.86%   -0.1%     
=========================================
  Files          14       14             
  Lines         998     1003      +5     
=========================================
+ Hits          798      801      +3     
- Misses        200      202      +2
Impacted Files Coverage Δ
src/display.jl 86.48% <60%> (-4.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f8496...95af0c9. Read the comment docs.

@ajkeller34
Copy link
Collaborator

ajkeller34 commented Jun 9, 2019

Merged into rigetti/Unitful.jl. will merge here

@giordano giordano closed this Jun 9, 2019
@ajkeller34 ajkeller34 reopened this Jun 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #213 into master will decrease coverage by 0.09%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #213     +/-   ##
=========================================
- Coverage   79.95%   79.86%   -0.1%     
=========================================
  Files          14       14             
  Lines         998     1003      +5     
=========================================
+ Hits          798      801      +3     
- Misses        200      202      +2
Impacted Files Coverage Δ
src/display.jl 86.48% <60%> (-4.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f8496...95af0c9. Read the comment docs.

@ajkeller34 ajkeller34 merged commit 7cd81f4 into PainterQubits:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants