Make Unitful.promote_to_derived usable again
#252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix PainterQubits#237 Seems like `ResistanceFreeUnits` where renamed to `ElectricalResistanceFreeUnits` without testing `Unitful.promote_to_derived()`
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 78.08% 78.08%
=======================================
Files 15 15
Lines 1054 1054
=======================================
Hits 823 823
Misses 231 231
Continue to review full report at Codecov.
|
|
Thanks for the PR! I must admit not having paid much attention to this function because I feel there is probably a better solution to the problem it solves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #237
ResistanceFreeUnitswhere renamed toElectricalResistanceFreeUnitswithout testingUnitful.promote_to_derived()in this commit.