Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unitless dispatch for more trig functions #387

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

derikk
Copy link
Contributor

@derikk derikk commented Oct 20, 2020

Dispatch on unitless quantities (like 10m/3km) for inverse and hyperbolic trig functions. Fixes #332.

Dispatch on unitless quantities (like `10m/3km`) for inverse and
hyperbolic trig functions. Fixes PainterQubits#332.
@giordano
Copy link
Collaborator

Awesome, thank you so much!

Project.toml Outdated Show resolved Hide resolved
Bump to 1.5.0

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #387 into master will decrease coverage by 2.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   83.16%   80.41%   -2.75%     
==========================================
  Files          15       15              
  Lines        1283     1195      -88     
==========================================
- Hits         1067      961     -106     
- Misses        216      234      +18     
Impacted Files Coverage Δ
src/Unitful.jl 100.00% <ø> (ø)
src/quantities.jl 94.08% <ø> (-0.01%) ⬇️
src/complex.jl 83.33% <0.00%> (-16.67%) ⬇️
src/display.jl 87.50% <0.00%> (-6.33%) ⬇️
src/range.jl 77.77% <0.00%> (-6.23%) ⬇️
src/units.jl 82.87% <0.00%> (-3.61%) ⬇️
src/promotion.jl 40.00% <0.00%> (-3.48%) ⬇️
src/logarithm.jl 66.07% <0.00%> (-3.09%) ⬇️
src/conversion.jl 83.87% <0.00%> (-2.70%) ⬇️
src/types.jl 89.36% <0.00%> (-2.64%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac587b...9024dab. Read the comment docs.

@giordano giordano merged commit b44c335 into PainterQubits:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dispatches in the unitless case
3 participants