Restrict Levels to real quantities
#400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 83.20% 83.20%
=======================================
Files 15 15
Lines 1280 1280
=======================================
Hits 1065 1065
Misses 215 215
Continue to review full report at Codecov.
|
giordano
reviewed
Jan 12, 2021
Comment on lines
+283
to
+284
| const ReferenceQuantity = Union{RealQuantity, IsRootPowerRatio{S,<:RealQuantity} where S} | ||
|
|
There was a problem hiding this comment.
Maybe define before the first use?
There was a problem hiding this comment.
For that, we would need to move the definition of IsRootPowerRatio as well. I have no problem with that, what do you think?
There was a problem hiding this comment.
Ok, yeah, it's better to not move stuff around for no good reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398. This allows only real quantities in
Levels (for the value as well as the reference quantity).