-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support InverseFunctions #622
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 16 16
Lines 1491 1491
=======================================
Hits 1328 1328
Misses 163 163 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I would wait for the Julia 1.9.0 release before merging this, just in case something about the "package extension interface" is still changed before the release. |
Well, then I won't insist, but note there are many very different packages that use extensions already: https://juliahub.com/ui/Search?q=extensions&type=code&f=Project.toml. |
As expected, package extensions didn't change in the actual 1.9 release, and this PR code does not change either. |
Test failure seems to be an |
This is JuliaTesting/Aqua.jl#105. It looks like Aqua wants the sections ordered Edit: We could just change the order to the one Aqua prefers, |
Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
@sostock could you please register the version as well? |
Regarding the limitation to v1.9 - why not making InverseFunctions a required depencency on <=v1.8? InverseFunctions is extremely lightweight - even on v1.9, using an extension probably won't save even half a millisecond of load time. |
I just went for the 1.9-only approach because it's easiest (implement + convince to accept), that's the only reason. |
Ok if I do a PR to extend it to <v1.9? |
See #652 |
Useful in, for example:
Only works on 1.9+, no changes on earlier julias.