Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[CORE-2010] removed the update statements for severity and category #2177

Merged
merged 1 commit into from May 2, 2024

Conversation

santhosh-challa
Copy link
Collaborator

Description

We are not persisting user updates on Policy category and severity. They are getting back to their original state post redeploy as we have update statements.

Problem

As the policy metadata script contains many update queries, redeploy updating the severity and category for many policies.

Solution

Removed all the update statements and updated their insert statement to contain the correct category and severity values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran the script in saasdev, and checked the pre and post-count of policies.

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • New and existing unit tests pass locally with my changes

Other Information:

List any documentation updates that are needed for the Wiki

Copy link

⚠️ DELETE statement found in the changes of SQL files. Requesting review from @santhosh and @Arun.

@santhosh-challa
Copy link
Collaborator Author

santhosh-challa commented Apr 30, 2024

Please use this https://github.dev/PaladinCloud/CE/pull/2177 to see the diff.

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@santhosh-challa santhosh-challa merged commit c99357a into master May 2, 2024
59 checks passed
@santhosh-challa santhosh-challa deleted the fix/core-2010/pocily-changes branch May 2, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants