Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed navigation in asset distribution and modified violation de… #690

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: fixed navigation in asset distribution and modified violation de… #690

merged 1 commit into from
Nov 30, 2022

Conversation

sidharthjain-zemoso
Copy link
Collaborator

Description

  1. fixed navigation in asset distribution when clicked on each tile.
  2. modified violation details to include qualys data

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ranadheer-b
ranadheer-b approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@ranadheer-b ranadheer-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dheerajkholia-paladin dheerajkholia-paladin merged commit 42976de into master Nov 30, 2022
@dheerajkholia-paladin dheerajkholia-paladin deleted the fix/asset-distribution branch November 30, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhosh-challa santhosh-challa santhosh-challa approved these changes

@dheerajkholia-paladin dheerajkholia-paladin dheerajkholia-paladin approved these changes

@ranadheer-b ranadheer-b ranadheer-b approved these changes

@raviteja-mandala raviteja-mandala Awaiting requested review from raviteja-mandala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sidharthjain-zemoso @santhosh-challa @dheerajkholia-paladin @ranadheer-b