Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RESOURCE_NAME_PREFIX #719

Merged

Conversation

PaladinCloudJohn
Copy link
Contributor

@PaladinCloudJohn PaladinCloudJohn commented Dec 16, 2022

Added RESOURCE_NAME_PREFIX to the default local options and cleaned up some comment language in the file.

Description

RESOURCE_NAME_PREFIX should be added to default.local.py so users can change it there instead of directly in common.py which could create conflicts with future versions.

Docs: Updates the language for some of the comments in default.local.py since those are the ones most likely to be read by developers

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update
    If this is added our troubleshooting documentation should point users to modify local.py instead of common.py

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • added RESOURCE_NAME_PREFIX to my local.py file instead of modifying common.py and was able to deploy Paladin Cloud with a new prefix.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

Other information:

Added RESOURCE_NAME_PREFIX to the default local options and cleaned up some comment language
Copy link
Collaborator

@rnithinpaladin rnithinpaladin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@santhosh-challa santhosh-challa merged commit 304142c into PaladinCloud:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants