feat : Gcp load balance quic protocol #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S target proxy is not configured with QUIC protocol>
shefalibisht1992
requested review from
dheerajkholia-paladin and
AishwaryaKulkarni97
| "ruleArn": "arn:aws:events:us-east-1:***REMOVED***:rule/Enable_Quic_Protocol_For_Load_Balancer", | ||
| "status": "ENABLED", | ||
| "userId": "ASGC", | ||
| "displayName": "Configure API Restriction for API Keys", |
There was a problem hiding this comment.
Please check if the displayName is correct for this policy
…S target proxy is not configured with QUIC protocol> updated display name for the rule
shefalibisht1992
changed the title
# Conflicts: # jobs/gcp-discovery/src/main/java/com/tmobile/pacbot/gcp/inventory/collector/LoadBalancerCollector.java
shefalibisht1992
requested review from
dheerajkholia-paladin and
AishwaryaKulkarni97
dheerajkholia-paladin
approved these changes
Jan 25, 2023
# Conflicts: # installer/resources/lambda_rule_engine/files/rule_engine_cloudwatch_gcp_rules.json # installer/resources/pacbot_app/files/DB_Policy.sql # jobs/gcp-discovery/src/main/java/com/tmobile/pacbot/gcp/inventory/collector/LoadBalancerCollector.java # jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/constants/PacmanRuleConstants.java
|
SonarCloud Quality Gate failed. |
AishwaryaKulkarni97
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GCP Load balancer HTTPS target proxy is not configured with QUIC protocol.
This policy identifies Load Balancer HTTPS target proxies which are not configured with QUIC protocol. Enabling QUIC protocol in load balancer target https proxies adds advantage by establishing connections faster, stream-based multiplexing, improved loss recovery, and eliminates head-of-line blocking
Fixes # (GCP Load balancer HTTPS target proxy is not configured with QUIC protocol.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
GCP data collector was run to gather the new data of quic negotiation. The generated gcp load balancer file was uploaded to s3 batch. Data shipper was then run to fetch this data in the elastic search. Last, the new rule was run against the data and hence checked accordingly.
Checklist: