Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mandatory tags from installer #765

Merged
merged 5 commits into from
Jan 25, 2023
Merged

fix: Mandatory tags from installer #765

merged 5 commits into from
Jan 25, 2023

Conversation

dheerajkholia-paladin
Copy link
Contributor

@dheerajkholia-paladin dheerajkholia-paladin commented Jan 23, 2023 •
edited

Description

  • Modified installer to inject mandatory tags to configuration

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

Other information:

@dheerajkholia-paladin
fix: Mandatory tags from installer
3a099b6 
- Modified installer to inject mandatory tags to configuration
@dheerajkholia-paladin
fix: Mandatory tags from installer
914684e 
- Added procedure to update the mandatory tag filters
- Removed hard coded tag filters
@dheerajkholia-paladin
fixing sonar issues
5755136
@dheerajkholia-paladin
fix:Mandatory tag filter
09d485b
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

rnithinpaladin
rnithinpaladin approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@rnithinpaladin rnithinpaladin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installer changes looks good

@dheerajkholia-paladin dheerajkholia-paladin merged commit 20039fd into master Jan 25, 2023
@dheerajkholia-paladin dheerajkholia-paladin deleted the fix/mandatory-tag-installer branch January 25, 2023 11:12
rnithinpaladin
rnithinpaladin reviewed Jan 25, 2023
View reviewed changes
installer/resources/pacbot_app/files/DB.sql
@@ -96,6 +96,7 @@ SET @AZURE_ENABLED='$AZURE_ENABLED';
SET @GCP_ENABLED='$GCP_ENABLED';
SET @JOB_SCHEDULER_NUMBER_OF_BATCHES='$JOB_SCHEDULER_NUMBER_OF_BATCHES';
SET @EVENT_BRIDGE_PRIFIX= '$EVENT_BRIDGE_PRIFIX';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space after "="

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnithinpaladin rnithinpaladin rnithinpaladin approved these changes

@santhosh-challa santhosh-challa santhosh-challa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dheerajkholia-paladin @santhosh-challa @rnithinpaladin