-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Gcp loadbalancer https target proxy configured with default ssl policy instead of custom ssl policy #768
Merged
dheerajkholia-paladin
merged 10 commits into
master
from
Gcp_loadbalancerHTTPS_target_proxy_configured_with_default_SSL_policy_instead_of_custom_SSL_policy
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustom ssl policy instead of default ssl policy
…red_with_default_SSL_policy_instead_of_custom_SSL_policy
shefalibisht1992
requested review from
AishwaryaKulkarni97 and
dheerajkholia-paladin
January 24, 2023 05:55
AishwaryaKulkarni97
suggested changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please check the resolutionUrl in policyTable
- Remove gcp-discovery dependency from pom.xml as this is for local testing only
AishwaryaKulkarni97
approved these changes
Jan 24, 2023
…red_with_default_SSL_policy_instead_of_custom_SSL_policy
Kudos, SonarCloud Quality Gate passed! |
dheerajkholia-paladin
approved these changes
Jan 25, 2023
dheerajkholia-paladin
deleted the
Gcp_loadbalancerHTTPS_target_proxy_configured_with_default_SSL_policy_instead_of_custom_SSL_policy
branch
January 25, 2023 06:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GCP Load balancer target https proxy should be configured with custom SSL policy instead of default SSL policy.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Jobexector was run to generate data file. The file was uploaded in the s3 batch and shipper was run to fetch the data in the elastic search. Moreover, all three rules written were tested and also, unit test have been created and run against each rule.
Checklist:
Other information: