Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Gcp loadbalancer https target proxy configured with default ssl policy instead of custom ssl policy #768

Conversation

shefalibisht1992
Copy link
Contributor

@shefalibisht1992 shefalibisht1992 commented Jan 24, 2023

Description

GCP Load balancer target https proxy should be configured with custom SSL policy instead of default SSL policy.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Jobexector was run to generate data file. The file was uploaded in the s3 batch and shipper was run to fetch the data in the elastic search. Moreover, all three rules written were tested and also, unit test have been created and run against each rule.

  • Test A : Job Executor and shipper and policy executor
  • Test B : Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

Other information:

Copy link
Contributor

@AishwaryaKulkarni97 AishwaryaKulkarni97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please check the resolutionUrl in policyTable
  2. Remove gcp-discovery dependency from pom.xml as this is for local testing only

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

@dheerajkholia-paladin dheerajkholia-paladin merged commit 00a1b48 into master Jan 25, 2023
@dheerajkholia-paladin dheerajkholia-paladin deleted the Gcp_loadbalancerHTTPS_target_proxy_configured_with_default_SSL_policy_instead_of_custom_SSL_policy branch January 25, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants