Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added client side filters for policy-knowledgebase, admin/polic… #846

Merged
merged 4 commits into from
Mar 13, 2023
Merged

feat: added client side filters for policy-knowledgebase, admin/polic… #846

merged 4 commits into from
Mar 13, 2023

Conversation

sidharthjain-zemoso
Copy link
Collaborator

@sidharthjain-zemoso sidharthjain-zemoso commented Feb 17, 2023 •
edited

Description

  1. Added client side filters for policy-knowledgebase, admin/policy and compliance overview list in dashboard.
  2. Removed server side search and added client side search in above screens until we have server side filter.
  3. Made admin/policies to load complete data on load and removed onscroll data load.

Fixes # (issue)

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

@sidharthjain-zemoso sidharthjain-zemoso force-pushed the feat/client-side-filter branch 5 times, most recently from 71ebb67 to 764d352 Compare February 21, 2023 13:35
ranadheer-b
ranadheer-b approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@ranadheer-b ranadheer-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sidharthjain-zemoso sidharthjain-zemoso merged commit 75f954e into master Mar 13, 2023
@sidharthjain-zemoso sidharthjain-zemoso deleted the feat/client-side-filter branch March 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhosh-challa santhosh-challa santhosh-challa approved these changes

@ranadheer-b ranadheer-b ranadheer-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sidharthjain-zemoso @santhosh-challa @ranadheer-b