-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: violationID in details UI #966
Merged
santhosh-challa
merged 4 commits into
PaladinCloud:master
from
arifa11111:Enhancement/ViolationID-in-details-UI
Mar 17, 2023
Merged
Added: violationID in details UI #966
santhosh-challa
merged 4 commits into
PaladinCloud:master
from
arifa11111:Enhancement/ViolationID-in-details-UI
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...acman-features/secondary-components/policy-violation-desc/policy-violation-desc.component.ts
Outdated
Show resolved
Hide resolved
astra1
suggested changes
Mar 15, 2023
...acman-features/secondary-components/policy-violation-desc/policy-violation-desc.component.ts
Outdated
Show resolved
Hide resolved
...man-features/secondary-components/policy-violation-desc/policy-violation-desc.component.html
Outdated
Show resolved
Hide resolved
...man-features/secondary-components/policy-violation-desc/policy-violation-desc.component.html
Outdated
Show resolved
Hide resolved
arifa11111
requested review from
astra1 and
abdulkudduszemoso
and removed request for
santhosh-challa,
sidharthjain-zemoso,
astra1 and
abdulkudduszemoso
March 15, 2023 13:14
astra1
reviewed
Mar 15, 2023
...man-features/secondary-components/policy-violation-desc/policy-violation-desc.component.html
Outdated
Show resolved
Hide resolved
plyubich
requested review from
plyubich,
sidharthjain-zemoso,
arunpaladin and
santhosh-challa
and removed request for
astra1
March 15, 2023 15:00
plyubich
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good solution - approved
sidharthjain-zemoso
approved these changes
Mar 16, 2023
santhosh-challa
approved these changes
Mar 17, 2023
Thank you, @arifa11111, for being a contributor. Congrats on your first Paladin Cloud merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display ViolationID in the Details UI
Fixes #884
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist:
Other information:
List any documentation updates that are needed for the Wiki
Attachment
Before Modification
After Modification