Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Account management fixes #967

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix: Account management fixes #967

merged 2 commits into from
Mar 17, 2023

Conversation

dheerajkholia-paladin
Copy link
Contributor

@dheerajkholia-paladin dheerajkholia-paladin commented Mar 15, 2023 •
edited

Description

  • Corrected get account list response
  • Added validate for azure and qualys
  • Modified delete account to effect immediately
  • Enabling gcp and azure enabled flag from add account operation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore (no code changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Other information:

List any documentation updates that are needed for the Wiki

@dheerajkholia-paladin
fix: Account management fixes
2441eb3 
- Corrected get account list response
- Added validate for azure and qualys
- Modified delete account to effect immediately
- Enabling gcp and azure enabled flag from add account operation
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
2.6% 2.6% Duplication

@dheerajkholia-paladin dheerajkholia-paladin merged commit e224561 into master Mar 17, 2023
@dheerajkholia-paladin dheerajkholia-paladin deleted the fix/account-management branch March 17, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhosh-challa santhosh-challa santhosh-challa approved these changes

@ranadheer-b ranadheer-b ranadheer-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dheerajkholia-paladin @santhosh-challa @ranadheer-b