Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests(outputs): fix corrupted parameters object on MSVC when using findOutputOrFail #618

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

Palakis
Copy link
Contributor

@Palakis Palakis commented Nov 27, 2020

Description

Fixes a crash when trying to use GetOutputInfo, StartOutput or StopOutput commands.

Motivation and Context

Fixes #553

How Has This Been Tested?

Tested OS(s): Windows 10 20H2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Palakis Palakis added the bug label Nov 27, 2020
@Palakis Palakis added this to the 4.9 milestone Nov 27, 2020
@Palakis Palakis self-assigned this Nov 27, 2020
@Palakis Palakis merged commit 1fef069 into 4.x-current Nov 27, 2020
@Palakis Palakis deleted the bugfix/output-commands-crash branch November 27, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output requests fail with 'missing request parameters`
1 participant