Implement login for Admin and Super-Admin

[tasneemkoushar]

Is your feature request related to a problem? Please describe.
Admins of several organizations may control the personnel and operations of their own organizations using talawa-admin. Presently, when you attempt to connect into talawa-admin, you are logged in as super-admin and are able to access information for other organizations in addition to your own.
You can refer to the image below.

Describe the solution you'd like
The login screen should stay the same, but when a user enters their credentials, it should automatically determine if they are an admin or a super-admin. Although the super admin might travel down through all the organizations, the admin should only be allowed access to their specific organization.

Describe alternatives you've considered
The contributor can come up with her/ his own ideas.

Approach to be followed

• We want to minimize changes to the existing design. Keep the current design.
• Code coverage for all files editor must be 100%

Additional context

• API calls may have to be modified and the relevant issues created

[Manoramsharma]

Hi @tasneemkoushar , I would like to work on this issue. We just need to render the existing code over a condition of pre determining the user as admin and super-admin just after the login.

[tasneemkoushar]

@Manoramsharma What's the status?

[Manoramsharma]

Hi @tasneemkoushar I have done with the asked changes but as I already mentioned in talawa-admin channel I am getting that yarn error, which is producing unnecessary changes by changing yarn.lock file due to which I am unable to make a PR. Here is the link to the issue which I mentioned.
https://thepalisadoes-dyb6419.slack.com/archives/C01RPC00K0D/p1677756698705999

[palisadoes]

Please merge your repo with the upstream, then reinstall the packages. There have been many changes.

[palisadoes]

@Manoramsharma Did you get this fixed?

[Manoramsharma]

Still this error? The problem is many of our packages are deprecated that are present in our `yarn.lock` file so modification in yarn.lock file is requested which I forbidden by using `yarn --immutable` flag in yarn command for installing the dependencies , If I use `yarn` simply to install the dependencies it will modify the yarn.lock file which is not accepted

[Manoramsharma]

Also @palisadoes Talawa-admin is using yarn v1 which is deprecated and not maintained anymore. So, getting errors with it is trivial. If we try upgrading it to newer version the whole app breaks.

[Manoramsharma]

@palisadoes @tasneemkoushar kindly go through this conversation :
https://thepalisadoes-dyb6419.slack.com/archives/C01RPC00K0D/p1678100750081939?thread_ts=1678100476.001339&cid=C01RPC00K0D

[palisadoes]

Why is this not affecting others? Are you adding new packages?

[Manoramsharma]

Why is this not affecting others? Are you adding new packages?

It's done, basically only the v1 versions will be fine for working with talawa-admin as it uses v1 only. The issue i was getting was due to my latest version of yarn i.e 3.4.1. So if anyone with the latest version of yarn , run yarn command in the root of the talawa-admin project the latter can modify our yarn.lock that i was facing from last few days.So I brought down my version to v1 . I already pinned the conversation on Talawa-admin channel

[palisadoes]

1. Please submit a PR for this.
2. Should we create an issue to upgrade packages for Talawa-Admin in the mean time?

[faraz16iqbal]

@palisadoes is this issue still open?

[anshgoyalevil]

@faraz16iqbal

Thanks for contributing to Talawa projects.

This issue is already assigned to @Manoramsharma

Please check other issues across different Talawa Repos, and select the ones which are not assigned to anyone

[xoldd]

Why is this not affecting others? Are you adding new packages?

Yarn v1 has reached end of life. Currently yarn is on v3 and it's not backward compatible, because there's many core changes related to its internal workings. Talawa-admin is deeply integrated with yarn v1 and create-react-app(this too is a cause for major disruptions and warnings) and making use of yarn v3 breaks the app.

[palisadoes]

@xoldyckk Should we create an issue to upgrade to Yarn v3?

[xoldd]

@xoldyckk Should we create an issue to upgrade to Yarn v3?

Yeah. Technically if it's going to be done, there's no need to upgrade to yarn v3. We can simply start using npm. Then both talawa-api and talawa-admin will be using the same package manager.

[palisadoes]

I'll make it npm

[Manoramsharma]

@xoldyckk Should we create an issue to upgrade to Yarn v3?

Yeah. Technically if it's going to be done, there's no need to upgrade to yarn v3. We can simply start using npm. Then both talawa-api and talawa-admin will be using the same package manager.

It will be easier to manage in case of npm , also when both of our projects will be using the same package manager there will be less breaking changes.