Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend for configurable session-management #1637

Open
chandel-aman opened this issue Jan 6, 2024 · 17 comments
Open

Backend for configurable session-management #1637

chandel-aman opened this issue Jan 6, 2024 · 17 comments
Labels

Comments

@chandel-aman
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, the timeout for Talawa-Admin is hard-coded in Talawa-Api. However, there is no feature to set a custom timeout for different organizations.

Describe the solution you'd like

Implement configurable session timeout for each organization and provide admins and super-admins the ability to access and change the session timeout for an organization, with the default timeout set to 30 minutes.

Describe alternatives you've considered
NA

Additional context

Related to the issue in Talawa-Admin #1305.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Jan 6, 2024
@Cioppolo14
Copy link
Contributor

@chandel-aman This is now assigned to you. Please wait to submit PRs until you are assigned an issue. Also, take note of @palisadoes comment in the PR you submitted.

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Jan 6, 2024
@palisadoes
Copy link
Contributor

This would be much better served at the Community level with a single value for all organizations. Therefore it would be managed by the SuperAdmin using this profile page for the configuration

This must be implemented as a single value for all organizations

@chandel-aman
Copy link
Contributor Author

This would be much better served at the Community level with a single value for all organizations. Therefore it would be managed by the SuperAdmin using this profile page for the configuration

* [Add the ability to change pre-login imagery talawa-admin#1334 (comment)](https://github.com/PalisadoesFoundation/talawa-admin/issues/1334#issuecomment-1879522861)

This must be implemented as a single value for all organizations

Correct me if I'm wrong.

  1. You're proposing that the session timeout be configurable at the community level, implying that organizations would fall under the community umbrella, and the session timeout data should be applicable universally to all the organizations under that community.
  2. Additionally, you're recommending that only super-admins should have the authority to update the session timeout, excluding admins from this privilege.

@palisadoes
Copy link
Contributor

yes

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 18, 2024
chandel-aman added a commit to chandel-aman/talawa-api that referenced this issue Jan 21, 2024
chandel-aman added a commit to chandel-aman/talawa-api that referenced this issue Feb 3, 2024
chandel-aman added a commit to chandel-aman/talawa-api that referenced this issue Feb 10, 2024
@xoldd
Copy link
Contributor

xoldd commented Feb 18, 2024

@palisadoes what is the need for session timeouts per organization?

Is talawa application meant to be similar to slack in that for each organization there has to be a seperate customizable authentication flow? Users first create a talawa account to gain access to the application and organizations. Then they would have to sign in to each organization seperately and follow seperate authentication flows specific to those organizations.

Or is it meant to be similar to how discord communities are managed? Users sign in once, get a global session, get to choose which organization they want to join. When the session expires they have to sign in to the talawa application again. The only difference being that here only talawa admins would be able to create organizations unlike discord where normal users can make their own discord communities.

Superadmin is an ambiguous term that's why I've used the (talawa) admin term here.

user roles:- ADMIN/USER
organization member roles:- MODERATOR/MEMBER

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 19, 2024
@palisadoes
Copy link
Contributor

It's like discord. Only admins can create orgs, with global session management across orgs.

@palisadoes
Copy link
Contributor

Unassigning due to inactivity

@lakshz
Copy link
Contributor

lakshz commented Feb 26, 2024

I would like to work on this.

@Olatade
Copy link

Olatade commented Feb 26, 2024

Our policy is to assign no more than one issue to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@chandel-aman
Copy link
Contributor Author

@palisadoes
I understand that I was unassigned from this issue due to inactivity, and I apologize for not being able to complete it earlier. I had some health issues that prevented me from working. However, I would like to take ownership of this issue again as I have already implemented it. Could you please reassign it to me? Thank you for your understanding.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 11, 2024
@jyotiv737
Copy link

@chandel-aman Are you working on this issue?

@chandel-aman
Copy link
Contributor Author

@chandel-aman Are you working on this issue?

Yes, I have raised the PR for this.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 20, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 31, 2024
@palisadoes
Copy link
Contributor

Unassigning due to no activity in the PR

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 13, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants