Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspection GitHub Action Fails on Push #1745

Closed
palisadoes opened this issue Jan 26, 2024 · 4 comments
Closed

Inspection GitHub Action Fails on Push #1745

palisadoes opened this issue Jan 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

Describe the bug

Our current GitHub action that inspects the schema is only implemented on pushes. This means that schema errors may not be detected until after the PR has been merged

To Reproduce

Steps to reproduce the behavior:

  1. Have a schema error.
  2. It is not detected by the pull request action
  3. The PR is merged
  4. Schema error is detected
    1. https://github.com/PalisadoesFoundation/talawa-api/actions/runs/7673337932/job/20915758114

Expected behavior

  1. The Check Schema job in the inspect.yml file must be moved to the pull-request.yml file
    1. https://github.com/PalisadoesFoundation/talawa-api/blob/develop/.github/workflows/inspect.yml
    2. https://github.com/PalisadoesFoundation/talawa-api/blob/develop/.github/workflows/pull-request.yml
  2. The inspect.yml file must be removed
  3. The Check Schema job must:
    1. automatically detect the target branch of the PR and do its testing against the equivalent branch in Talawa Admin (if required)
    2. run independently of any other jobs in the pull-request.yml file

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added bug Something isn't working CI/CD GitHub Action labels Jan 26, 2024
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Jan 26, 2024
@akhilender-bongirwar
Copy link
Contributor

I would like to work on this issue.

@aialok
Copy link

aialok commented Jan 27, 2024

@palisadoes , #1696 in this issue, we are already merging the inspect.yml to push.yml.

Can I work on this issue?
Close this if #1696 don't make sense now.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
@palisadoes
Copy link
Contributor Author

For the reasons stated here we need this in pull requests instead.

It's causing hardship. Sorry about not finding this one. I remember creating it but didn't find it in my search.

@palisadoes palisadoes reopened this Jan 27, 2024
@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 27, 2024

Closing for the other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants