Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and test GitHub action to lint all PRs before submission #235

Closed
palisadoes opened this issue Apr 23, 2021 · 10 comments · Fixed by #239
Closed

Add and test GitHub action to lint all PRs before submission #235

palisadoes opened this issue Apr 23, 2021 · 10 comments · Fixed by #239
Assignees
Labels
good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

We need to lint all code as part of the pull request process.

  1. The commands for the actions file can be found at the beginning of the documentation of this outdated GitHub action
  2. We will need the action to be activated only on a pull request. We have an example of how to do that in the Talawa repo
  3. Make the action be defined in a file named linter.yml

Test and make sure it doesn't break the code. Try running the linter on the code base as proof.

@palisadoes palisadoes added the good first issue Good for newcomers label Apr 23, 2021
@github-actions github-actions bot added documentation Improvements or additions to documentation unapproved Unapproved for Pull Request labels Apr 23, 2021
@XshubhamX
Copy link
Contributor

XshubhamX commented Apr 24, 2021

Can i work on this issue @palisadoes sir

@palisadoes
Copy link
Contributor Author

@XshubhamX Look at the examples in Talawa There is an action for issues, and another for pull requests.

@palisadoes palisadoes removed the documentation Improvements or additions to documentation label Apr 28, 2021
@XshubhamX
Copy link
Contributor

Ok Sir @palisadoes i will have a look at it.

@Sagar2366
Copy link
Contributor

@XshubhamX what's the progress on this issue ?
This is one of priority item for us. If you are not available please let us know, someone else can take over on this issue.

@XshubhamX
Copy link
Contributor

@Sagar2366 sir I'm currently working on talawa-admin as the whole code of that needs to be converted from vuejs to reactjs sorry sir I won't be able to work on this issue I would have informed earlier.

@yasharth291
Copy link
Contributor

@Sagar2366 sir

@yasharth291
Copy link
Contributor

@Sagar2366 sir amul dhungel has asked to fix it please assign this to him

@mihdas
Copy link
Contributor

mihdas commented May 14, 2021

Can I try working on this? @palisadoes @Sagar2366.

@mihdas
Copy link
Contributor

mihdas commented May 14, 2021

Added action to lint, however unable to merge as many js files contain errors

@palisadoes
Copy link
Contributor Author

@mihdas you will need to lint the entire code base as part of the PR. We had to do the same with Talawa and now things are much better with conflicts.

palisadoes added a commit that referenced this issue May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants