-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and test GitHub action to lint all PRs before submission #235
Comments
Can i work on this issue @palisadoes sir |
@XshubhamX Look at the examples in Talawa There is an action for issues, and another for pull requests. |
Ok Sir @palisadoes i will have a look at it. |
@XshubhamX what's the progress on this issue ? |
@Sagar2366 sir I'm currently working on talawa-admin as the whole code of that needs to be converted from vuejs to reactjs sorry sir I won't be able to work on this issue I would have informed earlier. |
@Sagar2366 sir |
@Sagar2366 sir amul dhungel has asked to fix it please assign this to him |
Can I try working on this? @palisadoes @Sagar2366. |
Added action to lint, however unable to merge as many js files contain errors |
@mihdas you will need to lint the entire code base as part of the PR. We had to do the same with Talawa and now things are much better with conflicts. |
We need to lint all code as part of the pull request process.
linter.yml
Test and make sure it doesn't break the code. Try running the linter on the code base as proof.
The text was updated successfully, but these errors were encountered: