Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTP feature while signing up #245

Closed
XshubhamX opened this issue May 18, 2021 · 6 comments
Closed

OTP feature while signing up #245

XshubhamX opened this issue May 18, 2021 · 6 comments
Assignees

Comments

@XshubhamX
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It will be great if an OTP can verify the user's email ID whether it is legit or not. This can be done by using some libraries like Sendmail(for sending OTP), OTP generator(for generation different OTP).

When the user will send signup data, the mutation that will be called should be generatOTP which will send OTP to the user's email and if this OTP is correct, the signup mutation will be called and user data get saved.

This task requires work with a frontend contributor.

@palisadoes sir can I work on this enhancement.

@github-actions github-actions bot added enhancement unapproved Unapproved for Pull Request labels May 18, 2021
@palisadoes
Copy link
Contributor

palisadoes commented May 18, 2021

Please work with @yasharth291 or someone who would be interested in updating Talawa admin accordingly.

  1. We will need to enable the feature using Talawa-Admin. The configuration parameters for the mail server will need to be updated there.
  2. This will need to be an optional feature activated by the administrator.

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label May 18, 2021
@XshubhamX
Copy link
Contributor Author

@palisadoes sir Ok I will contact him and will explain him my approach.

@XshubhamX
Copy link
Contributor Author

@palisadoes sir when the user will signup they will use talawa app so the otp need to be verified there only so i think there is some work which needs to be done in frontend also

@palisadoes
Copy link
Contributor

Please create all the necessary child issues for each of the subsystems that will need to be updated. Others will be able to assist you.

@XshubhamX
Copy link
Contributor Author

Ok Sir sure

@palisadoes
Copy link
Contributor

@XshubhamX As I haven't heard back from you. I'm going to close PR #248 and #245. We prefer to go with an email service for the reasons stated previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants