Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests for select_organization_view_model.dart #1004

Closed
palisadoes opened this issue Nov 21, 2021 · 7 comments · Fixed by #1291
Closed

Unittests for select_organization_view_model.dart #1004

palisadoes opened this issue Nov 21, 2021 · 7 comments · Fixed by #1291
Assignees
@RandyKdev
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 21, 2021 •
edited

We will need unittests done for all methods, classes and functions found in this file.

Any widgets referenced in this file must also have unittests done

pre_auth_view_models/select_organization_view_model.dart

This file can be found in the lib/view_model directory

Parent Issue:

PR Acceptance Criteria
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 21, 2021
@palisadoes palisadoes mentioned this issue Nov 21, 2021
Closed
@palisadoes palisadoes added points 01 and removed unapproved Unapproved, needs to be triaged points 01 labels Nov 23, 2021
@M-A-D-A-R-A
Copy link

Hey, can u assign it to me. thanks.

@M-A-D-A-R-A
Copy link

M-A-D-A-R-A commented Dec 12, 2021 •
edited

The test cases that are written already are for pre_auth_screens.
Is there any example for pre_auth_view_model? @sumitra19jha

I couldn't able to find any.

@palisadoes palisadoes added the wip Work in Progress label Dec 28, 2021
@palisadoes palisadoes added test Testing application and removed wip Work in Progress labels Jan 16, 2022
@palisadoes
Copy link
Contributor Author

Unassigning. It's been over a month.

@palisadoes palisadoes added good first issue Good for newcomers unapproved Unapproved, needs to be triaged labels Mar 4, 2022
@RandyKdev
Copy link

Good day @palisadoes, I would like to work on this. Please can you assign it to me?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 31, 2022
@RandyKdev
Copy link

Good day @palisadoes, I have completed this issue, but with some minor changes.

The file select_organization_view_model.dart contains some functions, showOrganizationList and showSearchList whose sole purpose is to display views.

I think the file select_organization_view_model.dart, being a view model should not contain views. So I moved the two functions to the views folder.

I transferred both functions to the file lib/views/pre_auth_screens/select_organization.dart because that is the file handling the view for the select organization view model.

Is this ok?

@palisadoes
Copy link
Contributor Author

That is a useful insight. Yes, refactor the code accordingly.

@RandyKdev
Copy link

Ok, opening a PR now.

@RandyKdev RandyKdev mentioned this issue Apr 1, 2022
Merged
Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
@aviraldevv
Refactor: tests/utilities folder [Fixes: PalisadoesFoundation#1004 & …
956fc7a 
…#993 ] (PalisadoesFoundation#1088)

* Refactored utilities folder and fixed some mutation tests

* Minor fix

* Fixed lint issues
@palisadoes palisadoes mentioned this issue Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RandyKdev RandyKdev

Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Milestone
No milestone
3 participants
@palisadoes @RandyKdev @M-A-D-A-R-A