Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests for login_view_model.dart #1007

Open
palisadoes opened this issue Nov 21, 2021 · 21 comments · Fixed by #1185
Open

Unittests for login_view_model.dart #1007

palisadoes opened this issue Nov 21, 2021 · 21 comments · Fixed by #1185
Labels
good first issue Good for newcomers no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 21, 2021

We will need unittests done for all methods, classes and functions found in this file.

Any widgets referenced in this file must also have unittests done

pre_auth_view_models/login_view_model.dart

This file can be found in the lib/view_model directory

Parent Issue:

PR Acceptance Criteria

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 21, 2021
@palisadoes palisadoes added points 01 and removed unapproved Unapproved, needs to be triaged points 01 labels Nov 23, 2021
@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Dec 4, 2021
@palisadoes palisadoes added the wip Work in Progress label Dec 28, 2021
@nirala96
Copy link

nirala96 commented Jan 5, 2022

I am willing to work on this issue. Can you pls assign me?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Jan 5, 2022
@palisadoes palisadoes added test Testing application and removed wip Work in Progress labels Jan 16, 2022
@palisadoes
Copy link
Contributor Author

Reassigning it's been over 3 weeks.

@guptapriyanshu7
Copy link
Contributor

@palisadoes I would like to work on this.

@palisadoes
Copy link
Contributor Author

Reopening as the tests do not cover the new Firebase functionality. Coverage is low

@ALIRAZA17
Copy link

@palisadoes I would like to work on this. Please assign.

@palisadoes
Copy link
Contributor Author

@ALIRAZA17
Copy link

@noman2002 can you please assign this issue to me?

@noman2002
Copy link
Member

@ALIRAZA17 Assigned you 2 issues. Please work on them and try to get the coverage to 100%. Thank you.

@droy312
Copy link

droy312 commented Feb 13, 2023

Can I work on this issue?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 13, 2023
@noman2002
Copy link
Member

@droy312 Any update ?

@droy312
Copy link

droy312 commented Feb 20, 2023

Yes working in it. Submitted a PR related to another issue. Waiting for it's merge.

@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity. We need to give others a chance.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 23, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 5, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 19, 2024
@chiragtyagi2003
Copy link

chiragtyagi2003 commented Mar 20, 2024

Kindly assign this to me. @palisadoes

@Olatade Olatade assigned Olatade and chiragtyagi2003 and unassigned Olatade Mar 20, 2024
@Olatade Olatade removed the no-issue-activity No issue activity label Mar 20, 2024
@chiragtyagi2003
Copy link

@Olatade I have added some new tests, kindly review.

Copy link

github-actions bot commented Apr 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 1, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 5, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no-issue-activity No issue activity test Testing application
Projects
None yet
8 participants