Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests for edit_profile_view_model.dart #1013

Closed
palisadoes opened this issue Nov 21, 2021 · 6 comments · Fixed by #1192
Closed

Unittests for edit_profile_view_model.dart #1013

palisadoes opened this issue Nov 21, 2021 · 6 comments · Fixed by #1192
Labels
no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 21, 2021 •
edited

The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage.

We will need unittests done for all methods, classes and functions found in this file.

Any widgets referenced in this file must also have unittests done

after_auth_view_models/profile_view_models/edit_profile_view_model.dart

This file can be found in the lib/view_model directory

Parent Issue:

PR Acceptance Criteria
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 21, 2021
This was referenced Nov 21, 2021
Closed
Closed
@palisadoes palisadoes added points 01 and removed unapproved Unapproved, needs to be triaged points 01 labels Nov 23, 2021
@rahuldadz
Copy link

Please assign this issue to me !

@palisadoes palisadoes added the wip Work in Progress label Dec 28, 2021
@palisadoes
Copy link
Contributor Author

@rahuldadz Are you still working on this?

@palisadoes palisadoes mentioned this issue Jan 10, 2022
Closed
@palisadoes palisadoes added test Testing application and removed wip Work in Progress labels Jan 16, 2022
@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Jan 27, 2022
@guptapriyanshu7
Copy link
Contributor

@palisadoes I would like to work on this.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 2, 2022
@guptapriyanshu7 guptapriyanshu7 mentioned this issue Feb 5, 2022
Merged
Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
@anshgoyalevil
Add test for directives/authDirective.ts [Fixes PalisadoesFoundation#920
e8c19ec 
] (PalisadoesFoundation#1013)

* Create test for resolvers/Query/index.spec.ts

* Update index.spec.ts

* Create test for roleDirective.ts

* feat: use constants instead of env

* create directives/index.spec.ts

* refactor: update DirectChatMessage

* update some files

* add otp.ts

* update some files

* refactor: refactored GroupChat files

* remove duplicate helper and refactor utilities

* refactor acceptAdmin.spec.ts

* refactor 20 tests in mutation

* fix createAdmin.spec.ts tests

* fix blockUser.spec.ts

* refactor remaining files in 1-20 range

* refactor mutation folder 21-40 files

* add test for authDirective.ts
@palisadoes palisadoes mentioned this issue Nov 26, 2023
Open
@palisadoes
Copy link
Contributor Author

Reopening as coverage is < 66.67%

@palisadoes palisadoes reopened this Nov 26, 2023
@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 22, 2023
@Cioppolo14
Copy link

Closing this issue as coverage is now 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity No issue activity test Testing application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added tests for EditProfilePageViewModel guptapriyanshu7/talawa
4 participants
@palisadoes @Cioppolo14 @guptapriyanshu7 @rahuldadz