Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests for like_button_view_model.dart #1020

Closed
palisadoes opened this issue Nov 21, 2021 · 10 comments · Fixed by #1105 or #1209
Closed

Unittests for like_button_view_model.dart #1020

palisadoes opened this issue Nov 21, 2021 · 10 comments · Fixed by #1105 or #1209
Assignees
@ahluwaliatikant
Labels
wip Work in Progress

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 21, 2021 •
edited

The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage.

We will need unittests done for all methods, classes and functions found in this file.

Any widgets referenced in this file must also have unittests done

widgets_view_models/like_button_view_model.dart

This file can be found in the lib/view_model directory

Parent Issue:

PR Acceptance Criteria
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 21, 2021
@palisadoes palisadoes mentioned this issue Nov 23, 2021
Closed
@palisadoes palisadoes added points 01 and removed unapproved Unapproved, needs to be triaged points 01 labels Nov 23, 2021
@saraljain12
Copy link

Hey, I am ready to take on this kindly tell me more about it and assign it to me

@palisadoes
Copy link
Contributor Author

Thanks @saraljain12. This is an important task. We need to get our code test coverage to be much better.

  1. Check this link on how to create Flutter Unit Tests for more details.
  2. Put your tests in the test/ directory. Check the files there for examples on how to proceed.
  3. Contact @CyberWake, @rutvik11062000 and/or @sumitra19jha for guidance. They will have suggestions on the directory structure to use and more

@CyberWake
Copy link
Contributor

Let me know is you need some help dm me on slack if needed.

@saraljain12
Copy link

Thanks, sure. Kindly give me the slack link
and also demo organization for logging in to app

@CyberWake
Copy link
Contributor

@ritik Kumar Srivastava my user name or find by my mail ritikfbd@gmail.com

@aashimawadhwa
Copy link
Member

Let me know is you need some help dm me on slack if needed.

can u provide me the link of slack channel ?

@palisadoes
Copy link
Contributor Author

Let me know is you need some help dm me on slack if needed.

can u provide me the link of slack channel ?

http://slack.palisadoes.org/

@palisadoes palisadoes added the wip Work in Progress label Dec 28, 2021
@palisadoes
Copy link
Contributor Author

@saraljain12 Are you still working on this?

@nishnatadebnath nishnatadebnath mentioned this issue Jan 5, 2022
Merged
@palisadoes
Copy link
Contributor Author

@palisadoes palisadoes reopened this Jan 27, 2022
@ahluwaliatikant
Copy link
Contributor

@palisadoes, I would like to work on this. Please assign it to me.

@ahluwaliatikant ahluwaliatikant mentioned this issue Feb 13, 2022
Merged
Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
@anshgoyalevil
Fix type errors in the codebase [Fixes PalisadoesFoundation#1018] (Pa…
70921f5 
…lisadoesFoundation#1020)

* Create test for resolvers/Query/index.spec.ts

* Update index.spec.ts

* Create test for roleDirective.ts

* feat: use constants instead of env

* create directives/index.spec.ts

* refactor: update DirectChatMessage

* update some files

* add otp.ts

* update some files

* refactor: refactored GroupChat files

* remove duplicate helper and refactor utilities

* refactor acceptAdmin.spec.ts

* refactor 20 tests in mutation

* fix createAdmin.spec.ts tests

* fix blockUser.spec.ts

* refactor remaining files in 1-20 range

* refactor mutation folder 21-40 files

* add test for authDirective.ts

* fix type errors issue PalisadoesFoundation#1018
@palisadoes palisadoes mentioned this issue Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahluwaliatikant ahluwaliatikant

Labels
wip Work in Progress
Projects
None yet
Milestone
No milestone
5 participants
@palisadoes @CyberWake @ahluwaliatikant @saraljain12 @aashimawadhwa