Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminological error] Misplaced description in set_url_page_test.dart #1031

Closed
Simran1604 opened this issue Dec 8, 2021 · 3 comments · Fixed by #1087
Closed

[Terminological error] Misplaced description in set_url_page_test.dart #1031

Simran1604 opened this issue Dec 8, 2021 · 3 comments · Fixed by #1087
Assignees
@Simran1604
Labels
bug Something isn't working test Testing application

Comments

@Simran1604
Copy link

Simran1604 commented Dec 8, 2021 •
edited

Describe the bug
While checking out the test files, I found a bug. Here it is "Testing if login button works" while it should be for the signup button.
To Reproduce
Steps to reproduce the behavior:

  1. Open test/widget_tests/pre_auth_screens/set_url_page_test.dart
  2. find the bug in lines 277 and 488

Screenshots
Screenshot (120)

Additional details
I would like to work on the issue @palisadoes pls assign me.
@github-actions github-actions bot added bug Something isn't working test Testing application unapproved Unapproved, needs to be triaged labels Dec 8, 2021
@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Dec 8, 2021
@palisadoes
Copy link
Contributor

@Simran1604 Is the fix, just changing the text on line 488?

@Simran1604
Copy link
Author

Yes

@palisadoes
Copy link
Contributor

OK

This was referenced Dec 9, 2021
Closed
Closed
@palisadoes palisadoes changed the title [Bug report] [Bug report] Error in Testing if login signup works Dec 20, 2021
@CyberWake CyberWake changed the title [Bug report] Error in Testing if login signup works [Terminological error] Misplaced description in set_url_page_test.dart Dec 24, 2021
@Simran1604 Simran1604 mentioned this issue Dec 28, 2021
Merged
palisadoes pushed a commit that referenced this issue Jan 3, 2022
@Simran1604
Solves #1031 (#1087)
1bc4218 
* Solves #1031

* test added

* added tests
Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
@kb-0311
Tests for src/utilities/creatorCheck.ts (PalisadoesFoundation#1031)
10b3e22 
* Tests for src/utilities/creatorCheck.ts

* linting

* applied @noman2002 's requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simran1604 Simran1604

Labels
bug Something isn't working test Testing application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solves #1031
Fixes issue #1031
Fixes issue #1031
2 participants
@palisadoes @Simran1604