Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update countlines.py and GitHub Action to also exclude directories #1196

Closed
palisadoes opened this issue Feb 6, 2022 · 0 comments · Fixed by #1197
Closed

Update countlines.py and GitHub Action to also exclude directories #1196

palisadoes opened this issue Feb 6, 2022 · 0 comments · Fixed by #1197
Assignees
@palisadoes
Labels
feature request test Testing application unapproved Unapproved, needs to be triaged

Comments

@palisadoes
Copy link
Contributor

We need to add a CLI option to countlines.py so that we can ignore directories (such as test/) in addition to existing files.
@palisadoes palisadoes self-assigned this Feb 6, 2022
@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Feb 6, 2022
@palisadoes palisadoes mentioned this issue Feb 6, 2022
Merged
palisadoes added a commit that referenced this issue Feb 6, 2022
@palisadoes @aman-singh7 @Simran1604
Fixes #1196 (#1197)
c953846 
* Stashing changes

* Revert "bfix: pause video when not inview (#999)"

This reverts commit 91a4a8a.

* Test

* Test

* (Revert 999 ) video player fixes (#1029)

* Update push.yaml

* Revert 1025 develop (#1028)

* Revert "Solves issue #1024 (#1025)"

This reverts commit fd20509.

* Revert "Solves issue #1024 (#1025)"

This reverts commit fd20509.

Co-authored-by: Peter Harrison <blackriver@simiya.com>

* Revert "bfix: pause video when not inview (#999)"

This reverts commit 91a4a8a.

* bfix: pause video when not inview

* chor: cleanup

* restore previous version of pubspec.lock

Co-authored-by: Peter Harrison <blackriver@simiya.com>
Co-authored-by: Simran Pattnaik <72657303+Simran1604@users.noreply.github.com>

* Test

* Test

* Test

* Removed excess coverage/ files

* Test

* Minor changes

* Stash

* test

* test

* Merged code with lastest upstream

* Updated code coverage to 34.2%

* Fixes 1196

* Fixed main.dart and pubspec.yaml

Co-authored-by: Peter Harrison <peter@colovore.com>
Co-authored-by: Aman <77198905+aman-singh7@users.noreply.github.com>
Co-authored-by: Simran Pattnaik <72657303+Simran1604@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palisadoes palisadoes

Labels
feature request test Testing application unapproved Unapproved, needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1196 palisadoes/talawa
1 participant
@palisadoes