Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecated UniLinksPlugin API #1204

Closed
palisadoes opened this issue Feb 11, 2022 · 8 comments
Closed

Fix Deprecated UniLinksPlugin API #1204

palisadoes opened this issue Feb 11, 2022 · 8 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 11, 2022

Describe the bug
When building the talawa app we get an UniLinksPlugin API warning message. This needs to be fixed

  • Our test code coverage percentage will need to be improved or maintained as part of this fix.
  • DO NOT ATTEMPT to solve the issue by ignoring the error message in build.gradle That is not a viable solution to this issue.

To Reproduce
Steps to reproduce the behavior:

  1. Build the Talawa app
  2. Monitor the console
  3. See message below

Expected behavior
There should be no deprecation warning

Actual behavior

Note: /home/xxx/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/uni_links-0.5.1/android/src/main/java/name/avioli/unilinks/UniLinksPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

Screenshots
N/A

Additional details
N/A

@palisadoes palisadoes added the bug Something isn't working label Feb 11, 2022
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Feb 11, 2022
@Tusharkhati
Copy link

can I work on this one?
thank you.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 13, 2022
Tusharkhati added a commit to Tusharkhati/talawa that referenced this issue Feb 14, 2022
after sync, this may solve the issue.
@noman2002
Copy link
Member

If no one is working on this. Please assign it to me.

@palisadoes palisadoes assigned noman2002 and unassigned noman2002 Feb 26, 2022
@CyberWake
Copy link
Contributor

@palisadoes this is not a talawa specific issue since this is a dependency in our codebase and it's stable enough inspite being deprecated there is nothing much we could handle in talawa codebase about it. Plus they have this issue being worked upon.

@palisadoes
Copy link
Contributor Author

Should we therefore find another package to use instead?

@CyberWake
Copy link
Contributor

This is a issue with the deprecated linting or so which I am looking upon basically this type or warning only appears once after the gradle is synced it doesn't appear on subsequent builds of the app. Plus this could be a mean while solution to get rid of such warning.

@palisadoes
Copy link
Contributor Author

In that case let's apply the suggested fix.

The fewer spurious messages the better

@CyberWake
Copy link
Contributor

@palisadoes I don't this works have tried this but it still gives the warning.
I have also gone through the depth of the issue this is basically due to the native java or kotlin code used in the dependency and the codebase of dependency is not perfectly linted. Due to which we get this warning.

@palisadoes
Copy link
Contributor Author

OK, I'll close the issue. Thanks

Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
PalisadoesFoundation#1204)

* completed tests for eventsByOrganizationConnection.spec.ts

* bug fix for unresolved tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants