Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unsafe PathProvider API #1205

Closed
palisadoes opened this issue Feb 11, 2022 · 6 comments
Closed

Fix Unsafe PathProvider API #1205

palisadoes opened this issue Feb 11, 2022 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 11, 2022

Describe the bug
When building the talawa app we get an PathProvider API warning message about the package using unchecked or unsafe operations. This needs to be fixed.

  • Our test code coverage percentage will need to be improved or maintained as part of this fix.
  • DO NOT ATTEMPT to solve the issue by ignoring the error message in build.gradle That is not a viable solution to this issue.

To Reproduce
Steps to reproduce the behavior:

  1. Build the Talawa app
  2. Monitor the console
  3. See message below

Expected behavior
There should be no warning

Actual behavior

Note: /home/xxx/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/path_provider_android-2.0.9/android/src/main/java/io/flutter/plugins/pathprovider/PathProviderPlugin.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Screenshots
N/A

Additional details
N/A

@palisadoes palisadoes added the bug Something isn't working label Feb 11, 2022
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Feb 11, 2022
@Tusharkhati
Copy link

can I work on this?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 14, 2022
@CyberWake
Copy link
Contributor

CyberWake commented Mar 9, 2022

@palisadoes this issue is from the dependency being used in the talawa codebase which comes in from the flutter community itself so I guess this should not be an issue at this point considering the point it is a dependency. Also here is a brief info regarding the issue

@palisadoes
Copy link
Contributor Author

Should we replace this with a supported package then?

@CyberWake
Copy link
Contributor

this is a best in class package maintained by the flutter community itself I feel this is safe to use since you can see this is one of the most liked packages in the flutter community for getting paths for local disk storage.

@CyberWake
Copy link
Contributor

Here is the link to it's rating. It's in top 13.

@palisadoes
Copy link
Contributor Author

OK. I'll close the issue

Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
…omplatible with talawa-api (PalisadoesFoundation#1205)

* Fixes PalisadoesFoundation#1167 Wrong steps in Installation.md

* Update INSTALLATION.md

* Fixes #PalisadoesFoundation#1665 Mutation joinPublicOrganization not complatible with talawa-api

* Fixes PalisadoesFoundation#1665 Mutation joinPublicOrganization not complatible with talawa-api

* Added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants