Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused RazorPay Support - This will be handled by the API in future #1206

Closed
palisadoes opened this issue Feb 11, 2022 · 2 comments · Fixed by #1224
Closed

Remove Unused RazorPay Support - This will be handled by the API in future #1206

palisadoes opened this issue Feb 11, 2022 · 2 comments · Fixed by #1224
Assignees
@noman2002
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 11, 2022 •
edited

Describe the bug
When building the talawa app we get an RazorPay API warning message. In early 2021, this support was considered, but we decided to include it as an API plugin. This means that talawa will need to interface with the talawa-api plugin and not RazorPay directly.

RazorPay support must be removed.

Our test code coverage percentage will need to be improved or maintained as part of this fix.

To Reproduce
Steps to reproduce the behavior:

  1. Build the Talawa app
  2. Monitor the console
  3. See message below

Expected behavior

RazorPay support must be removed so that there is no error.

Actual behavior

Note: /home/xxx/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/razorpay_flutter-1.2.7/android/src/main/java/com/razorpay/razorpay_flutter/RazorpayFlutterPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

Screenshots
N/A

Additional details
N/A
@palisadoes palisadoes added the bug Something isn't working label Feb 11, 2022
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Feb 11, 2022
@ayushvrma
Copy link

ayushvrma commented Feb 12, 2022 •
edited

hi can I work on this issue as it is a bit beginner friendly?
I'll have to remove it from the pubspec.yaml file and the profile_picture_view_model.dart too right?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 12, 2022
@ayushvrma ayushvrma mentioned this issue Feb 12, 2022
Closed
@ayushvrma ayushvrma removed their assignment Feb 23, 2022
@noman2002
Copy link
Member

Is this issue still open? Can I work on this one?

@noman2002 noman2002 mentioned this issue Feb 28, 2022
Merged
palisadoes pushed a commit that referenced this issue Mar 1, 2022
@noman2002
Fixes: #1206 Removed Unused RazorPay Support (#1224)
adaef15 
* added password validation criteria in all supported languages

* updated testcases in change_password_page.dart

* formatted change_password_page.test

* fixed depricated ImageCropper API

* Fixed Deprecated ImageCropper API

* Removed unused RazorPay support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noman2002 noman2002

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #1206 Removed Unused RazorPay Support noman2002/talawa
3 participants
@palisadoes @noman2002 @ayushvrma