-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views: Create tests for edit_profile_page.dart #1229
Comments
@palisadoes can you assign this to me. I have added the test locally need to make a PR. |
This is going to be the third pending issue in talawa you will be assigned. Make sure to complete some before asking for more. |
* Update .eslintrc.json * Update .eslintrc.json * Update .eslintrc.json
Reopening only 85% code coverage |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Would like to work on this. Please Assign me |
Can you please assign me this issue? |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
two tests has been written so far , one passed, still working on the second due to some issues encountered |
@nenezoe need any help ? |
yes i do |
yes i do |
@palisadoes i need help on some issues i'm encountering |
1 similar comment
@palisadoes i need help on some issues i'm encountering |
Please share the details of what you are exactly facing. I will try to help you. |
Dear PalisadoesFoundation/talawa
From this code
test('Get Image from Gallery Test', () async {
final File imageFile = File('path/to/image.jpg');
// Ensure that the mock returns a Future<File?> that resolves to a
non-null value
when(mockMultiMediaPickerService.getPhotoFromGallery(camera: false))
.thenAnswer((_) async => imageFile);
await viewModel.getImage();
expect(viewModel.imageFile, equals(imageFile));
});
i'm getting this error
test\views\after_auth_screens\profile_test\edit_profile_page_test.dart 15:7
MockMultiMediaPickerService.getPhotoFromGallery
test\views\after_auth_screens\profile_test\edit_profile_page_test.dart
52:40 main.<fn>.<fn>
type 'Null' is not a subtype of type 'Future<File?>'
Warm Regards
Okereke Juliet Nene
…On Fri, Mar 15, 2024 at 4:08 PM Shaik Azad ***@***.***> wrote:
Please share the details of what you are exactly facing. I will try to
help you.
—
Reply to this email directly, view it on GitHub
<#1229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKJCLEDY6I5QZEO323R23DYYMFIJAVCNFSM5PSLV3R2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJZHE4DMOJUGI2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
okay, Thanks, i will try it and get back to you
…On Sat, Mar 16, 2024 at 10:47 AM Shaik Azad ***@***.***> wrote:
Please use the below code snippet and let me know if this fixed your issue.
carbon.9.png (view on web)
<https://github.com/PalisadoesFoundation/talawa/assets/120930148/6ff31d1c-a0e3-4654-acd8-d4866e09524d>
—
Reply to this email directly, view it on GitHub
<#1229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKJCLGBIMBPGTGJRTZBBHDYYQILBAVCNFSM5PSLV3R2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBQGE4TGMJTGE2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@palisadoes where do i push the code for the edit_profile_page_test to ? |
To the |
i'm getting this when i push. remote: Permission to PalisadoesFoundation/talawa.git denied to nenezoe. |
You cannot push directly to our repositories. You have to create a pull request. There is lots of documentation on this on the GitHub site. |
@palisadoes please can you send me the link to the documentation on this |
Please use Google and YouTube |
@palisadoes there is no way i can access _multiMediaPickerService in the test file because it is a private class there without setting a setter and getter there to use it to access it in the other file |
You can use |
okay , thanks |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
unassigning due to no activity or PR |
I made a PR waiting for feedback from the people assigned to look at the PR
…On Sat, Apr 6, 2024 at 01:24 Crystian I ***@***.***> wrote:
unassigning due to no activity or PR
—
Reply to this email directly, view it on GitHub
<#1229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKJCLC2FILFYBK4MMVMVDDY346ETAVCNFSM5PSLV3R2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGA4DEMRQGA3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.
Tests need to be written for file
lib/views/after_auth_screens/profile/edit_profile_page.dart
test/views/after_auth_screens/profile_test/edit_profile_page_test.dart
. You may need to create the appropriate directory structure to do this.IMPORTANT:
Please refer to the parent issue on how to implement these tests correctly:
PR Acceptance Criteria
The text was updated successfully, but these errors were encountered: