Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for edit_profile_page.dart #1229

Open
palisadoes opened this issue Feb 28, 2022 · 35 comments · Fixed by #1258
Open

Views: Create tests for edit_profile_page.dart #1229

palisadoes opened this issue Feb 28, 2022 · 35 comments · Fixed by #1258
Labels
good first issue Good for newcomers no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/profile/edit_profile_page.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/after_auth_screens/profile_test/edit_profile_page_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 28, 2022
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 28, 2022
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed bug Something isn't working parent The issue is generating more sub-issues labels Mar 1, 2022
@CyberWake
Copy link
Contributor

CyberWake commented Mar 10, 2022

@palisadoes can you assign this to me. I have added the test locally need to make a PR.

@jadeharr jadeharr removed the unapproved Unapproved, needs to be triaged label Mar 10, 2022
@jadeharr
Copy link

This is going to be the third pending issue in talawa you will be assigned. Make sure to complete some before asking for more.

Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
* Update .eslintrc.json

* Update .eslintrc.json

* Update .eslintrc.json
@palisadoes
Copy link
Contributor Author

Reopening only 85% code coverage

@palisadoes palisadoes reopened this Nov 26, 2023
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 21, 2023
@AyushRaghuvanshi
Copy link

Would like to work on this. Please Assign me

@ilakshaygupt
Copy link

Can you please assign me this issue?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@nenezoe
Copy link

nenezoe commented Mar 15, 2024

two tests has been written so far , one passed, still working on the second due to some issues encountered

@Azad99-9
Copy link

@nenezoe need any help ?

@nenezoe
Copy link

nenezoe commented Mar 15, 2024

yes i do

@nenezoe
Copy link

nenezoe commented Mar 15, 2024

@nenezoe need any help ?

yes i do

@nenezoe
Copy link

nenezoe commented Mar 15, 2024

@nenezoe need any help ?

yes i do

@palisadoes i need help on some issues i'm encountering

1 similar comment
@nenezoe
Copy link

nenezoe commented Mar 15, 2024

@nenezoe need any help ?

yes i do

@palisadoes i need help on some issues i'm encountering

@Azad99-9
Copy link

Please share the details of what you are exactly facing. I will try to help you.

@nenezoe
Copy link

nenezoe commented Mar 15, 2024 via email

@Azad99-9
Copy link

Please use the below code snippet and let me know if this fixed your issue.

carbon(9)

@nenezoe
Copy link

nenezoe commented Mar 16, 2024 via email

@nenezoe
Copy link

nenezoe commented Mar 16, 2024

Please use the below code snippet and let me know if this fixed your issue.

carbon(9)

It works perfectly well, thanks alot

@nenezoe
Copy link

nenezoe commented Mar 17, 2024

@palisadoes where do i push the code for the edit_profile_page_test to ?

@palisadoes
Copy link
Contributor Author

To the develop branch of the repository

@nenezoe
Copy link

nenezoe commented Mar 17, 2024

To the develop branch of the repository

i'm getting this when i push. remote: Permission to PalisadoesFoundation/talawa.git denied to nenezoe.
fatal: unable to access 'https://github.com/PalisadoesFoundation/talawa.git/': The requested URL returned error: 403

@palisadoes
Copy link
Contributor Author

You cannot push directly to our repositories. You have to create a pull request. There is lots of documentation on this on the GitHub site.

@nenezoe
Copy link

nenezoe commented Mar 17, 2024

You cannot push directly to our repositories. You have to create a pull request. There is lots of documentation on this on the GitHub site.

@palisadoes please can you send me the link to the documentation on this

@palisadoes
Copy link
Contributor Author

palisadoes commented Mar 17, 2024

Please use Google and YouTube

@nenezoe
Copy link

nenezoe commented Mar 25, 2024

@palisadoes there is no way i can access _multiMediaPickerService in the test file because it is a private class there without setting a setter and getter there to use it to access it in the other file

@Azad99-9
Copy link

You can use locator<MultiMediaPickerService>() for accessing the service.

@nenezoe
Copy link

nenezoe commented Mar 26, 2024

locator()

okay , thanks

Copy link

github-actions bot commented Apr 6, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 6, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Apr 6, 2024
@Cioppolo14
Copy link

unassigning due to no activity or PR

@nenezoe
Copy link

nenezoe commented Apr 6, 2024 via email

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no-issue-activity No issue activity test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants