Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for set_url.dart #1248

Closed
palisadoes opened this issue Feb 28, 2022 · 3 comments · Fixed by #1255
Closed

Views: Create tests for set_url.dart #1248

palisadoes opened this issue Feb 28, 2022 · 3 comments · Fixed by #1255
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/pre_auth_screens/set_url.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/pre_auth_screens_test/set_url_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 28, 2022
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 28, 2022
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed bug Something isn't working parent The issue is generating more sub-issues labels Mar 1, 2022
@saksham-gt
Copy link

saksham-gt commented Mar 6, 2022

Can you assign me this issue? I've written tests for some part of the remaining coverage and created a PR as well. Would love to proceed with this issue. :) @palisadoes

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 6, 2022
@palisadoes
Copy link
Contributor Author

You will need to ask to be assigned the issue before submitting the PR. We will be strictly enforcing this rule shortly.

@saksham-gt
Copy link

My bad, won't repeat it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants