Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for set_url.dart - Part 2 #1270

Closed
palisadoes opened this issue Mar 14, 2022 · 3 comments · Fixed by #1297
Closed

Views: Create tests for set_url.dart - Part 2 #1270

palisadoes opened this issue Mar 14, 2022 · 3 comments · Fixed by #1297
Labels
good first issue Good for newcomers no-issue-activity No issue activity parent The issue is generating more sub-issues test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Mar 14, 2022

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

We are at 96% code coverage for this file, but it's an important part of the code base as it determines the success of communicating with the API.

image

Previous test work for this was done with this issue:

Tests need to be written for file lib/views/pre_auth_screens/set_url.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/pre_auth_screens_test/set_url_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
  • No functionality must be removed to achieve this goal

Section for attention

image

and

image

@palisadoes palisadoes added good first issue Good for newcomers test Testing application points 01 labels Mar 14, 2022
@github-actions github-actions bot added parent The issue is generating more sub-issues unapproved Unapproved, needs to be triaged labels Mar 14, 2022
@palisadoes palisadoes changed the title Views: Create tests for set_url.dart Views: Create tests for set_url.dart - Part 2 Mar 14, 2022
@RandyKdev
Copy link

Good day, I would like to have a shot at this.

@palisadoes
Copy link
Contributor Author

Reopening. We need to get the coverage to 100%

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no-issue-activity No issue activity parent The issue is generating more sub-issues test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants