Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views: Create tests for login.dart #1252

Closed
palisadoes opened this issue Feb 28, 2022 · 8 comments · Fixed by #1278
Closed

Views: Create tests for login.dart #1252

palisadoes opened this issue Feb 28, 2022 · 8 comments · Fixed by #1278
Assignees
@noman2002
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/pre_auth_screens/login.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/pre_auth_screens_test/login_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 28, 2022
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 28, 2022
@palisadoes palisadoes mentioned this issue Feb 28, 2022
Closed
@palisadoes palisadoes added points 01 and removed bug Something isn't working parent The issue is generating more sub-issues labels Mar 1, 2022
@saksham-gt
Copy link

Could you please assign me this issue?

@palisadoes palisadoes added unapproved Unapproved, needs to be triaged good first issue Good for newcomers and removed unapproved Unapproved, needs to be triaged labels Mar 1, 2022
@saksham-gt
Copy link

@palisadoes
It seems when I test this, it's not approving the test for Hide Password button even though in the application the IconButton is working fine. I've attached the related information here: https://thepalisadoes-dyb6419.slack.com/archives/CSW3ETABE/p1646415886967029

@palisadoes
Copy link
Contributor Author

Is there a mock package that could be used to assist? I've had difficulties in the past with testing network Image widgets, and had to use a mock to get it to work.

@saksham-gt
Copy link

I don't think that Mock packages will work here. We are not calling anything via HTTP call or fetching anything from database.

@saksham-gt
Copy link

Unassigning myself from this issue. Will work on it later. :)

@saksham-gt saksham-gt removed their assignment Mar 5, 2022
@noman2002
Copy link
Member

I would like to try this one also. Please assign it.

@palisadoes
Copy link
Contributor Author

@noman2002 You have been assigned three issues. Please wait until your PRs are merged before asking for this or other assignments.

@noman2002
Copy link
Member

@noman2002 You have been assigned three issues. Please wait until your PRs are merged before asking for this or other assignments.

ok, Thank you. I will wait for the PR to be merged. I thought I can work on other issues after creating a PR for the previously assigned.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 19, 2022
@noman2002 noman2002 mentioned this issue Mar 20, 2022
Merged
TheHazeEffect pushed a commit that referenced this issue Mar 22, 2022
@noman2002
Fixes #1252 Improved code coverage for login.dart (#1278)
de80747 
* added test for emailInputField

* added test for passwordInputField

* added test for iconButton and LoginButton
@palisadoes palisadoes mentioned this issue Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noman2002 noman2002

Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1252 Improved code coverage for login.dart noman2002/talawa
3 participants
@palisadoes @noman2002 @saksham-gt