Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded Heroku instance URL from code base #1256

Closed
palisadoes opened this issue Mar 7, 2022 · 2 comments · Fixed by #1259
Closed

Remove hard coded Heroku instance URL from code base #1256

palisadoes opened this issue Mar 7, 2022 · 2 comments · Fixed by #1259
Assignees
Labels
bug Something isn't working documentation Update documentation test Testing application

Comments

@palisadoes
Copy link
Contributor

Describe the bug

The Talawa App's default URL points to our Heroku test instance at talawa-graphql-api.herokuapp.com/graphql. This is not sustainable as real organizations should not be using our test instance for their members.

This needs to be fixed before we can do Alpha testing.

To Reproduce

Install Talawa. The default Heroku instance URL will be populated in the opening screen.

Expected behavior

  1. The hard coded Heroku instance URL needs to be removed from the code base
  2. The test cases need to be updated to reflect the change
  3. A Talawa INSTALLATION.md document needs to be created to let new developers know:
    1. How to install and run Talawa
    2. The API URLs to use for the most common use cases. (ie developers on a local machine, developers on a local machine using Docker, a remote machine) References to the API documentation may be useful here.
  4. Existing instructions in the README.md file should be moved to the new INSTALLATION.md file.
  5. A reference to the new installation document must be maintained.

The documentation needs to be FLAWLESS. Time will need to be taken to ensure that all new users understand what to do to make the app work. Step by step instructions will need to be provided.

Anyone must be able to run Talawa without incident when this bug issue is resolved.

Actual behavior

The URL defaults to our test Heroku instance.

Screenshots

N/A

Additional details

N/A

@palisadoes palisadoes added the bug Something isn't working label Mar 7, 2022
@github-actions github-actions bot added documentation Update documentation test Testing application unapproved Unapproved, needs to be triaged labels Mar 7, 2022
@noman2002
Copy link
Member

I am willing to work on this.
Do I have to just remove the hard-coded URL and fix the test and documentation.?

@palisadoes
Copy link
Contributor Author

Yes

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 9, 2022
palisadoes pushed a commit that referenced this issue Mar 14, 2022
…nd improved documentation. (#1259)

* added password validation criteria in all supported languages

* updated testcases in change_password_page.dart

* formatted change_password_page.test

* fixed depricated ImageCropper API

* Fixed Deprecated ImageCropper API

* Removed unused RazorPay support

* Removed hardcoded URL instance and created INSTALLATION.md

* Added link of Installation.md

* improved code coverage

* improved test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Update documentation test Testing application
Projects
None yet
2 participants